On 01/28/2016 12:49 AM, Hugh Dickins wrote: > On Wed, 27 Jan 2016, Mike Kravetz wrote: >> On 01/25/2016 05:50 AM, Mike Kravetz wrote: >>> On 01/25/2016 03:01 AM, Kirill A. Shutemov wrote: >>>> On Sun, Jan 24, 2016 at 05:57:12PM -0800, Mike Kravetz wrote: >>>>> - Adding shared page table (PMD) support to DAX much like that which exists >>>>> for hugetlbfs >>>> >>>> Shared page tables for hugetlbfs is rather ugly hack. >>>> >>>> Do you have any thoughts how it's going to be implemented? It would be >>>> nice to have some design overview or better proof-of-concept patch before >>>> the summit to be able analyze implications for the kernel. >>>> >>> >>> Good to know the hugetlbfs implementation is considered a hack. I just >>> started looking at this, and was going to use hugetlbfs as a starting >>> point. I'll reconsider that decision. >> >> Kirill, can you (or others) explain your reasons for saying the hugetlbfs >> implementation is an ugly hack? I do not have enough history/experience >> with this to say what is most offensive. I would be happy to start by >> cleaning up issues with the current implementation. > > I disagree that the hugetlbfs shared pagetables are an ugly hack. > What they are is a dark backwater that very few people are aware of, > which we therefore can very easily break or be broken by. > > I have regretted bringing them into mm for that reason, and have > thought that they're next in line for the axe, after those non-linear > vmas which Kirill dispatched without tears last year. But if you're > intent on making more use of them, exposing them to the light of day > is a fair alternative to consider. It is interesting to note that at least one DB vendor (my employer) is very aware of hugetlbfs shared pagetables, and takes advantage of them in their DB architecture. Their primary concern is the memory savings that sharing provides. I agree with you that very few people know about them. I didn't know they existed until informed by the DB team and I looked at the code. -- Mike Kravetz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
