Hi!
On Mon 25-01-16 14:33:57, Michal Hocko wrote:
> - GFP_NOFS is another one which would be good to discuss. Its primary
> use is to prevent from reclaim recursion back into FS. This makes
> such an allocation context weaker and historically we haven't
> triggered OOM killer and rather hopelessly retry the request and
> rely on somebody else to make a progress for us. There are two issues
> here.
> First we shouldn't retry endlessly and rather fail the allocation and
> allow the FS to handle the error. As per my experiments most FS cope
> with that quite reasonably. Btrfs unfortunately handles many of those
> failures by BUG_ON which is really unfortunate.
> Another issue is that GFP_NOFS is quite often used without any obvious
> reason. It is not clear which lock is held and could be taken from
> the reclaim path. Wouldn't it be much better if the no-recursion
> behavior was bound to the lock scope rather than particular allocation
> request? We already have something like this for PM
> pm_res{trict,tore}_gfp_mask resp. memalloc_noio_{save,restore}. It
> would be great if we could unify this and use the context based NOFS
> in the FS.
I like the idea that we'd protect lock scopes from reclaim recursion but the
effort to do so would be IMHO rather big. E.g. there are ~75 instances of
GFP_NOFS allocation in ext4/jbd2 codebase and making sure all are properly
covered will take quite some auditing... I'm not saying we shouldn't do
something like this, just you will have to be good in selling the benefits
:).
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
