tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git orangefs-untested head: 8af48090ac7697cc4380ea11c2c655d489d0baeb commit: 8af48090ac7697cc4380ea11c2c655d489d0baeb [10/10] orangefs: move wakeups into set_op_state_{serviced,purged}() config: x86_64-randconfig-x012-01201142 (attached as .config) reproduce: git checkout 8af48090ac7697cc4380ea11c2c655d489d0baeb # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In file included from fs/orangefs/acl.c:8:0: >> fs/orangefs/orangefs-kernel.h:108:49: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) ^ >> fs/orangefs/orangefs-kernel.h:108:49: warning: its scope is only this definition or declaration, which is probably not what you want fs/orangefs/orangefs-kernel.h: In function 'set_op_state_serviced': >> fs/orangefs/orangefs-kernel.h:110:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state = OP_VFS_STATE_SERVICED; ^ fs/orangefs/orangefs-kernel.h: At top level: fs/orangefs/orangefs-kernel.h:113:47: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) ^ fs/orangefs/orangefs-kernel.h: In function 'set_op_state_purged': fs/orangefs/orangefs-kernel.h:115:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state |= OP_VFS_STATE_PURGED; ^ -- In file included from fs/orangefs/orangefs-mod.c:11:0: >> fs/orangefs/orangefs-kernel.h:108:49: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) ^ >> fs/orangefs/orangefs-kernel.h:108:49: warning: its scope is only this definition or declaration, which is probably not what you want fs/orangefs/orangefs-kernel.h: In function 'set_op_state_serviced': >> fs/orangefs/orangefs-kernel.h:110:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state = OP_VFS_STATE_SERVICED; ^ fs/orangefs/orangefs-kernel.h: At top level: fs/orangefs/orangefs-kernel.h:113:47: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) ^ fs/orangefs/orangefs-kernel.h: In function 'set_op_state_purged': fs/orangefs/orangefs-kernel.h:115:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state |= OP_VFS_STATE_PURGED; ^ fs/orangefs/orangefs-mod.c: In function 'purge_inprogress_ops': >> fs/orangefs/orangefs-mod.c:304:24: warning: passing argument 1 of 'set_op_state_purged' from incompatible pointer type [-Wincompatible-pointer-types] set_op_state_purged(op); ^ In file included from fs/orangefs/orangefs-mod.c:11:0: fs/orangefs/orangefs-kernel.h:113:20: note: expected 'struct orangefs_kernel_op_s *' but argument is of type 'struct orangefs_kernel_op_s *' static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) ^ -- In file included from fs/orangefs/devorangefs-req.c:11:0: >> fs/orangefs/orangefs-kernel.h:108:49: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) ^ >> fs/orangefs/orangefs-kernel.h:108:49: warning: its scope is only this definition or declaration, which is probably not what you want fs/orangefs/orangefs-kernel.h: In function 'set_op_state_serviced': >> fs/orangefs/orangefs-kernel.h:110:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state = OP_VFS_STATE_SERVICED; ^ fs/orangefs/orangefs-kernel.h: At top level: fs/orangefs/orangefs-kernel.h:113:47: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) ^ fs/orangefs/orangefs-kernel.h: In function 'set_op_state_purged': fs/orangefs/orangefs-kernel.h:115:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state |= OP_VFS_STATE_PURGED; ^ fs/orangefs/devorangefs-req.c: In function 'orangefs_devreq_write_iter': >> fs/orangefs/devorangefs-req.c:415:25: warning: passing argument 1 of 'set_op_state_serviced' from incompatible pointer type [-Wincompatible-pointer-types] set_op_state_serviced(op); ^ In file included from fs/orangefs/devorangefs-req.c:11:0: fs/orangefs/orangefs-kernel.h:108:20: note: expected 'struct orangefs_kernel_op_s *' but argument is of type 'struct orangefs_kernel_op_s *' static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) ^ fs/orangefs/devorangefs-req.c:471:25: warning: passing argument 1 of 'set_op_state_serviced' from incompatible pointer type [-Wincompatible-pointer-types] set_op_state_serviced(op); ^ In file included from fs/orangefs/devorangefs-req.c:11:0: fs/orangefs/orangefs-kernel.h:108:20: note: expected 'struct orangefs_kernel_op_s *' but argument is of type 'struct orangefs_kernel_op_s *' static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) ^ -- In file included from fs/orangefs/waitqueue.c:16:0: >> fs/orangefs/orangefs-kernel.h:108:49: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) ^ >> fs/orangefs/orangefs-kernel.h:108:49: warning: its scope is only this definition or declaration, which is probably not what you want fs/orangefs/orangefs-kernel.h: In function 'set_op_state_serviced': >> fs/orangefs/orangefs-kernel.h:110:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state = OP_VFS_STATE_SERVICED; ^ fs/orangefs/orangefs-kernel.h: At top level: fs/orangefs/orangefs-kernel.h:113:47: warning: 'struct orangefs_kernel_op_s' declared inside parameter list static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) ^ fs/orangefs/orangefs-kernel.h: In function 'set_op_state_purged': fs/orangefs/orangefs-kernel.h:115:4: error: dereferencing pointer to incomplete type 'struct orangefs_kernel_op_s' op->op_state |= OP_VFS_STATE_PURGED; ^ fs/orangefs/waitqueue.c: In function 'purge_waiting_ops': >> fs/orangefs/waitqueue.c:37:23: warning: passing argument 1 of 'set_op_state_purged' from incompatible pointer type [-Wincompatible-pointer-types] set_op_state_purged(op); ^ In file included from fs/orangefs/waitqueue.c:16:0: fs/orangefs/orangefs-kernel.h:113:20: note: expected 'struct orangefs_kernel_op_s *' but argument is of type 'struct orangefs_kernel_op_s *' static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) ^ fs/orangefs/waitqueue.c: In function 'service_operation': fs/orangefs/waitqueue.c:167:9: error: implicit declaration of function 'wait_for_cancellation_downcall' [-Werror=implicit-function-declaration] ret = wait_for_cancellation_downcall(op); ^ fs/orangefs/waitqueue.c:169:9: error: implicit declaration of function 'wait_for_matching_downcall' [-Werror=implicit-function-declaration] ret = wait_for_matching_downcall(op); ^ fs/orangefs/waitqueue.c: At top level: fs/orangefs/waitqueue.c:384:12: error: static declaration of 'wait_for_matching_downcall' follows non-static declaration static int wait_for_matching_downcall(struct orangefs_kernel_op_s *op) ^ fs/orangefs/waitqueue.c:169:9: note: previous implicit declaration of 'wait_for_matching_downcall' was here ret = wait_for_matching_downcall(op); ^ fs/orangefs/waitqueue.c:490:12: error: static declaration of 'wait_for_cancellation_downcall' follows non-static declaration static int wait_for_cancellation_downcall(struct orangefs_kernel_op_s *op) ^ fs/orangefs/waitqueue.c:167:9: note: previous implicit declaration of 'wait_for_cancellation_downcall' was here ret = wait_for_cancellation_downcall(op); ^ fs/orangefs/waitqueue.c:384:12: warning: 'wait_for_matching_downcall' defined but not used [-Wunused-function] static int wait_for_matching_downcall(struct orangefs_kernel_op_s *op) ^ fs/orangefs/waitqueue.c:490:12: warning: 'wait_for_cancellation_downcall' defined but not used [-Wunused-function] static int wait_for_cancellation_downcall(struct orangefs_kernel_op_s *op) ^ cc1: some warnings being treated as errors vim +110 fs/orangefs/orangefs-kernel.h 102 OP_VFS_STATE_SERVICED = 4, 103 OP_VFS_STATE_PURGED = 8, 104 }; 105 106 #define set_op_state_waiting(op) ((op)->op_state = OP_VFS_STATE_WAITING) 107 #define set_op_state_inprogress(op) ((op)->op_state = OP_VFS_STATE_INPROGR) > 108 static inline void set_op_state_serviced(struct orangefs_kernel_op_s *op) 109 { > 110 op->op_state = OP_VFS_STATE_SERVICED; 111 wake_up_interruptible(&op->waitq); 112 } 113 static inline void set_op_state_purged(struct orangefs_kernel_op_s *op) --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: Binary data
