> -----Original Message----- > From: linux-fsdevel-owner@xxxxxxxxxxxxxxx [mailto:linux-fsdevel-owner@xxxxxxxxxxxxxxx] On Behalf Of Dave Chinner > Sent: Monday, January 11, 2016 6:22 AM > To: Fan Li > Cc: linux-fsdevel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] fs: fix bugs for __generic_block_fiemap() > > On Sat, Jan 09, 2016 at 04:50:34PM +0800, Fan Li wrote: > > Fix 3 bugs: > > 1. If there are more than two blocks of holes after the last > > extent of file, it would fail to add FIEMAP_EXTENT_LAST > > to the last extent. > > 2. len hasn't been updated correctly, if len > isize and > > start > 0. > > 3. If len is less than one block, it will be extended to > > one block. If start + len exceeds the boundary of the > > original block because of the extension, one extra block > > will be returned. > > > > And simplify the codes of __generic_block_fiemap() as well. > > One bug fix/change per patch, please, so they can be easily reviewed. OK, I have split it into three patches, but I'm afraid the fix for the first bug involves a lot of modification that can't be easily divided, I hope it's enough. Thanks. > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
