On Thu, Jan 07, 2016 at 04:15:52PM +0100, Jan Kara wrote: > On Thu 07-01-16 10:07:05, Benjamin LaHaise wrote: ... > > Why isn't this code placed in file_start_write() and file_end_write()? > > That makes more sense to me than sprinkling it in the aio code. > > Well, that would completely defeat the purpose of lockdep annotations for > fs freeze protection - we want lockdep to treat file_start_write() - > file_end_write() pair as a lock-unlock pair. But in case of AIO the unlock > will happen from a different process than lock and lockdep cannot handle > such cases. That's why for AIO we have to add some lockdep magic to avoid > false warnings. Okay, makes sense. Applied. I'll forward that with the other fix that is pending. -ben -- "Thought is the essence of where you are now." -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
