On Wed, Jan 6, 2016 at 12:25 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> Said that, I'm not sure it's the best approach. E.g. I2C_* stuff is
> defined only in one driver and if we are touching that code at all,
> we might as well take it out of fs/compat_ioctl.c and be done with
> that - just add ->compat_ioctl() to drivers/i2c/i2c-dev.c and move
> that crap over there
Yeah, that seems a sane thing to do as an alternative if somebody is
willing and able to actually test it..
> Oh, well - that can be done in followups, anyway. Applied, with s/filp/file/
> through the entire thing - I really don't like that naming convention.
>
> BTW, am I right assuming that it had been adopted from OS Design and
> Implementation way back when?
Examples of 'filp' for "struct file *" variable naming do seem to go
all the way back to 0.01. And yes, very old naming like that is
presumably influenced by either that or by Bach's unix design book.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
