> -----Original Message----- > From: Borislav Petkov [mailto:bp@xxxxxxxxx] > Sent: Wednesday, December 16, 2015 7:26 PM > To: Kweh, Hock Leong > Cc: Matt Fleming; Greg Kroah-Hartman; Ong, Boon Leong; LKML; linux- > efi@xxxxxxxxxxxxxxx; Sam Protsenko; Peter Jones; Andy Lutomirski; Roy > Franz; James Bottomley; Linux FS Devel; Anvin, H Peter; 'Matt Fleming' > Subject: Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi > firmware > > On Wed, Dec 16, 2015 at 11:09:50AM +0000, Kweh, Hock Leong wrote: > > So, my conclusion is that this module is not able to be tested on QEMU > > environment. > > That's not the point. > > The module should better handle writing to the device file gracefully > and not explode. Regardless of whether it is running on an EFI system or > not. > > efi_capsule_loader_init() simply loads the driver on *any* system, > even a !UEFI one. And when I write some garbage to the device file, it > explodes. > > What it should do instead is check whether it is being loaded on en EFI > system and whether all it needs to function properly is initialized > already, like runtime services. If not, it should refuse to load. > > -- > Regards/Gruss, > Boris. Hi Borislav, I catch your point now. I will fix that in v10 patch. Thanks & Regards, Wilson ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
