Re: [PATCH] fs/super.c: use && instead of & for warn_on condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 Sep 2015, Oleg Nesterov wrote:

> > --- a/fs/super.c
> > +++ b/fs/super.c
> > @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
> >  	else
> >  		ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
> >
> > -	WARN_ON(force_trylock & !ret);
> > +	WARN_ON(force_trylock && !ret);
> 
> OOPS! yes, this is a typo, thanks! Harmless in this particular case,
> but still.
> 
> Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Doesn't seem to be in linux-next as of today, so I am taking it now. 
Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux