On Wed 02-12-15 07:37:58, Dan Williams wrote: > On Wed, Dec 2, 2015 at 3:16 AM, Jan Kara <jack@xxxxxxx> wrote: > >> generic_quiesce_super and generic_bdi_gone, are the default operations > >> when a filesystem does not implement ->quiesce(), ->bdi_gone(). They > >> invalidate inodes and unmap DAX-inodes respectively. For now only > >> ->bdi_gone() has an associated super operation as xfs will implement > >> ->bdi_gone() in a later patch. > > > > So the patch looks good. Just for the callbacks to be generally useful we > > would need del_gendisk_queue() to be used for all devices, not just for > > pmem ones... But I guess this is better than nothing. > > Once this goes in I'll go back and convert nvme and sd to > del_gendisk_queue. That should give us coverage for the most > prominent block drivers. OK, that would be good enough. Feel free to add: Acked-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
