Re: [PATCH] fat: Allow time_offset to be upto 13 hours

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Kara <jack@xxxxxxx> writes:

> Currently we limit values of time_offset mount option to be between -12
> and 12 hours. However e.g. zone GMT+12 can have a DST correction on top
> which makes the total time difference 13 hours. Update the checks in
> mount option parsing to allow offset of upto 13 hours.

Hmmm, 13 is where come from?

TZ environment (of course, has much more complex format though. see
tzset(3)) offset is +-24 hours (total different can have more than
24). Well, so I feel, more or less, 12 is sane, and also 24 is sane. But
I'm not sure why 13?

Thanks.

> Reported-by: Volker Kuhlmann <list0570@xxxxxxxxxxxxxxx>
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---
>  fs/fat/inode.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 509411dd3698..2041031ab1c8 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1146,7 +1146,11 @@ static int parse_options(struct super_block *sb, char *options, int is_vfat,
>  		case Opt_time_offset:
>  			if (match_int(&args[0], &option))
>  				return -EINVAL;
> -			if (option < -12 * 60 || option > 12 * 60)
> +			/*
> +			 * Allow for GMT+-12 zones to have DST like
> +			 * corrections
> +			 */
> +			if (option < -13 * 60 || option > 13 * 60)
>  				return -EINVAL;
>  			opts->tz_set = 1;
>  			opts->time_offset = option;

-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux