On Thu, Nov 19, 2015 at 03:59:31PM -0500, Jeff Layton wrote:
> Ahh right -- good point. d_splice_alias does this:
>
> if (!inode) {
> __d_instantiate(dentry, NULL);
> goto out;
> }
> [...]
> out:
> security_d_instantiate(dentry, inode);
> d_rehash(dentry);
> return NULL;
>
> ...which is exactly what d_add does. So yeah, that change isn't
> strictly necessary. Still, it might be more future-proof to use
> d_splice_alias there if the semantics ever change...
Could be, I don't know.
May as well apply it (or not) independently of this series, though.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
