On Fri, 2015-11-13 at 09:00 -0800, Dan Williams wrote: > On Fri, Nov 13, 2015 at 8:48 AM, Toshi Kani <toshi.kani@xxxxxxx> wrote: > > On Thu, 2015-11-12 at 09:53 -0800, Dan Williams wrote: > > > Rather than punt on the numa node for these e820 ranges try to find a > > > better answer with memory_add_physaddr_to_nid() when it is available. > > > : > > > +#ifdef CONFIG_MEMORY_HOTPLUG > > > +static int e820_range_to_nid(resource_size_t addr) > > > +{ > > > + return memory_add_physaddr_to_nid(addr); > > > +} > > > +#else > > > +static int e820_range_to_nid(resource_size_t addr) > > > +{ > > > + return NUMA_NO_NODE; > > > +} > > > +#endif > > > > "linux/memory_hotplug.h" defines as follows. > > > > #ifdef CONFIG_NUMA > > extern int memory_add_physaddr_to_nid(u64 start); > > #else > > static inline int memory_add_physaddr_to_nid(u64 start) > > { > > return 0; > > } > > #endif > > > > So, memory_add_physaddr_to_nid() should be defined with #ifdef CONFIG_NUMA. > > > > #ifdef CONFIG_MEMORY_HOTPLUG > > int memory_add_physaddr_to_nid(u64 start) > > { > > > > I thought so too, but 0day reported this: > > https://lists.01.org/pipermail/kbuild-all/2015-November/014618.html Oh, I see. "memory_hotplug.h" has #ifdef CONFIG_MEMORY_HOTPLUG before the memory_add_physaddr_to_nid() prototype definition... Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html