On Fri, Oct 30, 2015 at 02:50:46PM -0700, Linus Torvalds wrote: > Anyway. This is a pretty simple patch, and I actually think that we > could just get rid of the "next_fd" logic entirely with this. That > would make this *patch* be more complicated, but it would make the > resulting *code* be simpler. Dropping next_fd would screw you in case of strictly sequential allocations... Your point re power-of-two allocations is well-taken, but then I'm not sure that kzalloc() is good enough here. Look: you have a bit for every 64 descriptors, i.e. byte per 512. On 10M case Eric had been talking about that'll yield 32Kb worth of your secondary bitmap. It's right on the edge of the range where vmalloc() becomes attractive; for something bigger it gets even worse... Currently we go for vmalloc (on bitmaps) once we are past 128K descriptors (two bitmaps packed together => 256Kbit = 32Kb). kmalloc() is very sensitive to size being a power of two, but IIRC vmalloc() isn't... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
