Re: [PATCH v13 2/5] gennvm: Generic NVM manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/29/2015 08:41 AM, Dongsheng Yang wrote:
On 10/28/2015 08:30 AM, Matias Bjørling wrote:
The implementation for Open-Channel SSDs is divided into media
[...]
+        lun->reserved_blocks = 2; /* for GC only */
+        lun->vlun.id = i;
+        lun->vlun.lun_id = i % dev->luns_per_chnl;
+        lun->vlun.chnl_id = i / dev->luns_per_chnl;

Please use do_div(). % would be not supported in some platforms, as
the kbuild pointed in V12.

Neither of those are 64-bit variables, which is where you end up with the problem on 32-bit archs.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux