The patch set looks good so far, and copy offload is important for CIFS/SMB3 (not just Windows/Mac/Samba but most servers support one of the various methods available to do this over the network via CIFS and also SMB2/SMB3). I have only implemented two ways of copy offload in cifs.ko so far but will look at adding the remaining mechanisms. Currently cifs.ko does have a similar restriction to the below one that you have in your patch1, but I was planning to relax it (as long as source and target are on the same server) since some of the important use cases are having the server do copy offload from one share to another. So we should support the case where the files are on the same file system type (nfs, cifs etc.) but not necessarily on the same superblock (for the case of cifs they will be on the same server, but with some forms of copy offload that would not necessarily have to be on the same server). The following check should be removed (an alternative would be to check that source and target are the same filesystem type ie nfs, or cifs or xfs etc. or simply let the file systems check file_in and file_out's validity) > + /* this could be relaxed once a method supports cross-fs copies */ > + if (inode_in->i_sb != inode_out->i_sb || > + file_in->f_path.mnt != file_out->f_path.mnt) > + return -EXDEV; -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
