On Thu, Oct 22, 2015 at 11:40 AM, Christoph Hellwig <hch@xxxxxx> wrote: > On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote: >> We don't want to hardcode default groups at subsystem >> creation time. We export: >> * configfs_register_group >> * configfs_unregister_group >> to allow drivers to programatically create/destroy groups >> later, after module init time. >> >> This is needed for IIO configfs support. > > This looks like a good start, and maybe we should merge it as is given > that merge window is about to end. But I have two requests, one trivial > and one not so: > > a) please provide kerneldoc comments for the new functions > b) just pass the name and item type and dynamically allocate the > actua group. With that we can avoid a lot of boilerplate code and > could also replace the horrible static sized defaults_groups array > in current users with your new function. Will try to see how quick I can do this. Eventually we can introduce the new function + use it in IIO and fix current users later. Thanks Christoph! Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
