On Wed, Oct 21, 2015 at 2:08 AM, Jan Kara <jack@xxxxxxx> wrote: > Sorry for replying to this email and not to patch posting directly but I > didn't find the original mail in any of my mailboxes... Forgive me for not including you on the initial posting. I'll add you to that series going forward. > On Tue 20-10-15 17:31:18, Dan Williams wrote: >> On Tue, Oct 20, 2015 at 5:01 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> > On Tue, Oct 20, 2015 at 11:31:45PM +0000, Williams, Dan J wrote: >> >> Here is a status summary of the topic-branches nvdimm.git is tracking >> >> for v4.4. Unless indicated these branches are not present in -next. >> >> Please ACK, NAK, or ask for a re-post of any of the below to disposition >> >> it for the merge window. >> >> >> >> === >> >> for-4.4/dax-fixes: >> >> === >> > ... >> >> Dave Chinner (5): >> >> xfs: fix inode size update overflow in xfs_map_direct() >> >> xfs: introduce BMAPI_ZERO for allocating zeroed extents >> >> xfs: Don't use unwritten extents for DAX >> >> xfs: DAX does not use IO completion callbacks >> >> xfs: add ->pfn_mkwrite support for DAX >> > >> > Please drop these. They have not been reviewed yet, and because >> > the changes affect more than just DAX (core XFS allocator >> > functionality was changed) these need to go through the XFS tree. >> > >> >> Ok, thanks for the heads up. For the get_user_pages() patches that >> build on these fixes I'm assuming your review bandwidth is in short >> supply to also give an XFS sign-off on those changes for 4.4? >> >> I'm wondering if we can take a conservative step forward with those >> patches for 4.4. if XFS and EXT4 interactions need more time to get >> worked out, which I believe they do, I can conceive just turning on >> get_user_pages() support for DAX-mappings of the raw block device. >> This would be via the new facility I posted yesterday: >> https://lists.01.org/pipermail/linux-nvdimm/2015-October/002512.html. >> While not very functional for applications it makes testing base DAX >> mechanisms straightforward. > > I had a look at the patch and I miss one thing: Why do we need bd_mutex > to protect faults? This is my main question for the RFC, I landed on bd_mutex as a big hammer primarily because I don't expect more than a handful of applications to be in a position to map a block device directly. Aside from needing admin privileges the application must also be satisfied with only having partitions to sub-divide the capacity. As far as I can see, a hypervisor is the only application that is compatible with the above constraints. It establishes a few mappings that exist for the lifetime of the guest and ends up with little to no contention on an mmap lock. > I see a comment there: > > /* check that the faulting page hasn't raced with bdev resize */ > > Is it really possible that bdev gets shrunk under us? Hum, looking into > fs/block_dev.c, probably it is. But there are other places - like DIO path > - assuming that block device mapping cannot just disappear from under us. I > wonder how that would cope with bdev size change... > > Also we only call invalidate_bdev() to invalidate page cache pages of the > bdev after resize which specifically skips any mmaped pages so bdev resizing > in presence of mmap is unreliable to say the least. True, new locking against resize just for mmap is hard to justify when there's no protection in other paths. Perhaps it is a case of userspace getting to keep the pieces if it decides to race resize vs i/o? At least with the pmem driver there's no risk that i/o will clobber random memory addresses past the end of the whole-disk-device since only partitions can be resized at run time. The base pmem device can only be resized while offline. > Anyway, bd_mutex seems like a big hammer in the fast path to protect against > rare size changes. Also nesting of bd_mutex under mmap_sem makes me > somewhat uneasy (I'd definitely wonder whether lockdep would not complain > about that)... Lockdep hasn't triggered to date, but I've only tried mapping the base block device with no filesystem present. I'll try a test that sets up both a base device mapping and one through an fs file on the same device. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
