Anna, On Mon, Oct 12, 2015 at 4:39 PM, Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> wrote: > I'm not a fan of the "one giant function" approach. Is there any way to split richacl_from_nfs4_acl() into several smaller functions? sure, parsing the usr/group identifier could be put in a separate function, for example. That function cannot stay as it is right now anyway --- we really need idmapper to tell us when an identifier string cannot be mapped to a uid or gid so that we can preserve that identifier. Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
