On Mon, 05 Oct, at 03:13:50PM, Borislav Petkov wrote: > On Tue, Oct 06, 2015 at 04:15:54AM +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong" <hock.leong.kweh@xxxxxxxxx> > > > > This patch export efi_capsule_supported() function symbol for capsule > > kernel module to use. > > > > Cc: Matt Fleming <matt.fleming@xxxxxxxxx> > > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@xxxxxxxxx> > > --- > > drivers/firmware/efi/capsule.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c > > index d8cd75c0..738d437 100644 > > --- a/drivers/firmware/efi/capsule.c > > +++ b/drivers/firmware/efi/capsule.c > > @@ -101,6 +101,7 @@ out: > > kfree(capsule); > > return rv; > > } > > +EXPORT_SYMBOL_GPL(efi_capsule_supported); > > So this one is still a separate patch. > > If you're going to ignore review comments, maybe I should stop wasting > my time reviewing your stuff... I agree that it makes sense to fold this patch into your PATCH 2, because then we know why we need the above symbol to be exported. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html