2015-10-04 8:29 GMT+02:00 Christoph Hellwig <hch@xxxxxxxxxxxxx>: > IS it just me or is this handler broke before and after this patch? It > only copies out the prefix, but not the actual xattr name. Well, squashfs appends the rest of the name in squashfs_listxattr, so it's not broken, just different. I have tried cleaning that up by converting the list operation into something like this instead: bool (*may_list)(struct dentry *dentry); The xattr name would always be copied into the buffer in iop->listxattr. But security_inode_listsecurity which is called from vfs_getxattr as well as nfs4_xattr_list_nfs4_label was getting in the way, and it's unclear to me how to best clean that up first. Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html