Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@xxxxxxxxxx] > Sent: Wednesday, August 12, 2015 6:03 AM > To: linux-kernel@xxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx; > linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH] f2fs: do not write any node pages related to orphan inodes > > We should not write node pages when deleting orphan inodes. > In order to do that, we can eaisly set POR_DOING flag earlier before entering > orphan inode routine. If no error occurs in recover_orphan_inodes, it will clear SBI_POR_DOING before return, so our protect region is broken since we remove SBI_POR_DOING setting in the beginning of recover_fsync_data. How about removing all SBI_POR_DOING related ops in recover_orphan_inodes? > > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > --- > fs/f2fs/recovery.c | 3 --- > fs/f2fs/super.c | 6 +++++- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index d2ef0c9..cdcca7c 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -545,9 +545,6 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) > > INIT_LIST_HEAD(&inode_list); > > - /* step #1: find fsynced inode numbers */ Nitpick, this makes the left comment "/* step #2: recover data */" looks strange, how about modifying the left one too? Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
