Re: [PATCH v2 24/35] ubifs: suspend & resume quota properly in ubifs_remount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/09/2015 05:24 AM, Richard Weinberger wrote:
Am 30.07.2015 um 07:48 schrieb Dongsheng Yang:
Signed-off-by: Dongsheng Yang <yangds.fnst@xxxxxxxxxxxxxx>
---
  fs/ubifs/super.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 6ed35e2..06dd7af 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2128,11 +2128,13 @@ static int ubifs_remount_fs(struct super_block *sb, int *flags, char *data)
  		err = ubifs_remount_rw(c);
  		if (err)
  			return err;
+		dquot_resume(sb, -1);
  	} else if (!c->ro_mount && (*flags & MS_RDONLY)) {
  		if (c->ro_error) {
  			ubifs_msg(c, "cannot re-mount R/O due to prior errors");
  			return -EROFS;
  		}
+		dquot_suspend(sb, -1);

Is it really safe to ignore the return values of both function?

Good point. I will do it.

Thanx
Yang

Beside of that,
Reviewed-by: Richard Weinberger <richard@xxxxxx>

Thanks,
//richard
.


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux