Am 30.07.2015 um 07:48 schrieb Dongsheng Yang: > We need to disable quota in umounting ubifs. So we have to > disable quota in ubifs_put_super(). But quota disable will > write quota file, and we have to budget for it. > > Signed-off-by: Dongsheng Yang <yangds.fnst@xxxxxxxxxxxxxx> > --- > fs/ubifs/super.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index 3609d7b..7031c16 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -2027,6 +2027,8 @@ static void ubifs_put_super(struct super_block *sb) > > ubifs_msg(c, "un-mount UBI device %d", c->vi.ubi_num); > > + if (!c->ro_mount) > + dquot_disable(sb, -1, DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED); I fear this will explode in your face. dquot_disable disables all inodes needed for quota support, once enabled you have to shut down quota support. IOW if someone remounts UBIFS read only or UBIFS does itself due to an error you'll leak inodes. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
