Hello, On Fri, Jul 03, 2015 at 03:02:13PM +0200, Jan Kara wrote: ... > OK, I agree with your device vs logical construct argument. However when > splitting pages based on avg throughput each cgroup generates, we know > nothing about actual amount of dirty pages in each cgroup so we may end up > writing much fewer pages than we originally wanted since a cgroup which was > assigned a big chunk needn't have many pages available. So your algorithm > is basically bound to undershoot the requested number of pages in some > cases... Sure, but the nr_to_write has never been a strict thing except when we're writing out everything. We don't overshoot them but writing out less than requested is not unusual. Also, note that write bandwidth is the primary measure that we base the distribution of dirty pages on. Sure, there can be cases where the two deviate but this is the better measure to use than, say, number of currently dirty pages. > Another concern is that if we have two cgroups with same amount of dirty > pages but cgroup A has them randomly scattered (and thus have much lower > bandwidth) and cgroup B has them in a sequential fashion (thus with higher > bandwidth), you end up cleaning (and subsequently reclaiming) more from > cgroup B. That may be good for immediate memory pressure but could be > considered unfair by the cgroup owner. > > Maybe it would be better to split number of pages to write based on > fraction of dirty pages each cgroup has in the bdi? The dirty pages are already distributed according to write bandwidth. Write bandwidth is the de-facto currency of dirty page distribution. If it can be shown that some other measure is better for this purpose, sure, but I don't see why we'd deviate just based on a vague feeling that something else might be better and given how these mechanisms are used I don't think going either way would matter a bit. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
