Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > In ovl_dentry_open(), ovl_drop_write() is called after vfs_open() - but is > > this actually necessary? Can't we just drop it post-copyup? After all, > > that's all we wanted the write lock for, right? > > Hmm, that could result in a race where remount r/o of upper fs comes > in between copy-up and vfs_open() so copy-up succeeds but the actual > open fails. It's harmless, though, and not very likely. So I guess > your patch is OK. That race is there anyway if there's no copy up, right? David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
