On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick <fabf@xxxxxxxxx> wrote: > Fix gcc -Wswitch-default warnings > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx> > --- > fs/affs/inode.c | 2 ++ > fs/affs/namei.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/fs/affs/inode.c b/fs/affs/inode.c > index 1734950..623398e 100644 > --- a/fs/affs/inode.c > +++ b/fs/affs/inode.c > @@ -143,6 +143,8 @@ struct inode *affs_iget(struct super_block *sb, unsigned long ino) > inode->i_op = &affs_symlink_inode_operations; > inode->i_data.a_ops = &affs_symlink_aops; > break; > + default: > + break; > } > > inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec > diff --git a/fs/affs/namei.c b/fs/affs/namei.c > index 181e05b..517926d 100644 > --- a/fs/affs/namei.c > +++ b/fs/affs/namei.c > @@ -237,6 +237,9 @@ affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) > //case ST_LINKDIR: > case ST_LINKFILE: > ino = be32_to_cpu(AFFS_TAIL(sb, bh)->original); > + break; > + default: > + break; How can this code path be reached? If I read your patch correctly it just silences gcc. If the code can be reached you need to take a proper action of not the warning is bogus. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
