On Thu, Apr 02, 2015 at 09:01:14AM -0700, Dan Williams wrote: > >> If anything I think these should be dev_dbg(). > > > > We do not have a dev at any of this point, and it does not > > belong to any specific device. > > Ah, true this is prior to the driver attaching... that said it seems > more relevant to print from probe() (where we do have a device) than > init where the device may remain idle due to some other policy. > > > Also I would like this > > _info and not _dbg so to always have it, also for production. > > See the chatter for a single SCSI disk the minimum we need > > is just the small print that tells all that we need (for now) > > Not sure we want to follow so closely in the footsteps of SCSI's chattiness. Defintively not! A single dev_info at ->probe time sounds ok, something like: dev_info(dev, "registering region [0x%pa:0x%zx]\n", &pmem->phys_addr, pmem->size); but there are plenty other drivers not that chatty, e.g. virtio and we're doing just fine for them. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
