On Tue, Mar 31, 2015 at 12:03:28PM -0400, Jeff Layton wrote: > v2: gracefully handle the case where some dentry pointers end up NULL > and be more dilligent about zeroing out dentry pointers > > We currently have a problem that SELinux policy is being enforced when > creating debugfs files. If a debugfs file is created as a side effect of > doing some syscall, then that creation can fail if the SELinux policy > for that process prevents it. > > This seems wrong. We don't do that for files under /proc, for instance, > so Bruce has proposed a patch to fix that. > > While discussing that patch however, Greg K.H. stated: > > "No kernel code should care / fail if a debugfs function fails, so > please fix up the sunrpc code first." > > This patch converts all of the sunrpc debugfs setup code to be void > return functins, and the callers to not look for errors from those > functions. > > This should allow rpc_clnt and rpc_xprt creation to work, even if the > kernel fails to create debugfs files for some reason. > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Acked-by: "J. Bruce Fields" <bfields@xxxxxxxxxxxx> > Signed-off-by: Jeff Layton <jeff.layton@xxxxxxxxxxxxxxx> > --- > include/linux/sunrpc/debug.h | 18 +++++++-------- > net/sunrpc/clnt.c | 4 +--- > net/sunrpc/debugfs.c | 52 ++++++++++++++++++++++++-------------------- > net/sunrpc/sunrpc_syms.c | 7 +----- > net/sunrpc/xprt.c | 7 +----- > 5 files changed, 41 insertions(+), 47 deletions(-) Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
