On Tue, Mar 31, 2015 at 05:21:15PM +0300, Boaz Harrosh wrote: > -static int pmem_probe(struct platform_device *pdev) > +static int pmem_alloc(struct resource *res, struct device *dev, > + struct pmem_device **o_pmem) > { please return the pmem device or an ERR_PTR() here. Except for that it looks fine for me, and it's exactly what we'd export for your PCIe device which would get an almost trivial pci_driver wrapper around it. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html