On Wed, Mar 25, 2015 at 02:21:53PM -0600, Ross Zwisler wrote: > What needed to be fixed with the partition support? I used to have real > numbers for first_minor and passed into alloc_disk(), but simplified it based > on code found in this commit in the nvme driver: > > 469071a37afc NVMe: Dynamically allocate partition numbers > > This has worked fine for me - is there some test case in which it breaks? Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all. > > +out_unmap: > > + pmem_unmapmem(pmem); > > +out_free_dev: > > + kfree(pmem); > > +out: > > This label is no longer used, and can be removed. Ok, fixed. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html