On Wed, Mar 25, 2015 at 10:10:31AM +0200, Boaz Harrosh wrote: > On 03/25/2015 04:22 AM, Dave Chinner wrote: > > On Tue, Mar 24, 2015 at 08:14:59AM +0200, Boaz Harrosh wrote: > <> > > > > Then we have wider problem with DAX, then: sync doesn't work > > properly. i.e. if we still has write mapped pages, then we haven't > > flushed dirty cache lines on write-mapped files to the persistent > > domain by the time sync completes. > > > > So, this shouldn't be some special case that only the freeze code > > takes into account - we need to make sure that sync (and therefore > > freeze) flushes all dirty cache lines and marks all mappings > > clean.... > > > > This is not how I understood it and how I read the code. > > The sync does happen, .fsync of the FS is called on each > file just as if the user called it. If this is broken it just > needs to be fixed there at the .fsync vector. POSIX mandate > persistence at .fsync so at the vfs layer we rely on that. right now, the filesystems will see that there are no dirty pages on the inode, and then just sync the inode metadata. They will do nothing else as filesystems are not aware of CPU cachelines at all. > So everything at this stage should be synced to real media. Actually no. This is what intel are introducing new CPU instructions for - so fsync can flush the cpu caches and commit them to th persistence domain correctly. > What does not happen is writeback. since dax does not have > any writeback. Which is precisely the problem we need to address - we don't need writeback to a block device, but we do need the dirty CPU cachelines flushed and the mappings cleaned. > And because of that nothing turned the > user mappings to read only. This is what I do here but > instead of write-protecting I just unmap because it is > easier for me to code it. That doesn't mean it is the correct solution. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
