On Sat, Mar 14, 2015 at 03:35:58PM +0100, Oleg Nesterov wrote: > On 03/12, Josh Triplett wrote: > > > > @@ -598,7 +600,9 @@ static void exit_notify(struct task_struct *tsk, int group_dead) > > if (group_dead) > > kill_orphaned_pgrp(tsk->group_leader, NULL); > > > > - if (unlikely(tsk->ptrace)) { > > + if (tsk->autoreap) { > > + autoreap = true; > > + } else if (unlikely(tsk->ptrace)) { > > int sig = thread_group_leader(tsk) && > > thread_group_empty(tsk) && > > !ptrace_reparented(tsk) ? > > @@ -612,8 +616,10 @@ static void exit_notify(struct task_struct *tsk, int group_dead) > > } > > > > tsk->exit_state = autoreap ? EXIT_DEAD : EXIT_ZOMBIE; > > - if (tsk->exit_state == EXIT_DEAD) > > + if (tsk->exit_state == EXIT_DEAD) { > > list_add(&tsk->ptrace_entry, &dead); > > + clonefd_do_notify(tsk); > > + } > > And even ignoring semantics issues, this change looks simply buggy anyway ;) > > How can we do list_add(&tsk->ptrace_entry) if it is traced by _another_ task? > ->ptrace_entry is used by debugger. That list_add was there before; I didn't change that. I just added a second line inside the EXIT_DEAD case, to call clonefd_do_notify (which wakes up potential callers of poll/read). - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html