On Thu, 12 Mar 2015 18:54:42 +0300 Andrew Vagin <avagin@xxxxxxxxxxxxx> wrote: > v2: use seq_has_overflowed() properly --- a/fs/proc/fd.c~proc-show-locks-in-proc-pid-fdinfo-x-v2 +++ a/fs/proc/fd.c @@ -57,17 +57,15 @@ static int seq_show(struct seq_file *m, real_mount(file->f_path.mnt)->mnt_id); show_fd_locks(m, file, files); - ret = seq_has_overflowed(m); - if (ret) + if (seq_has_overflowed(m)) goto out; if (file->f_op->show_fdinfo) file->f_op->show_fdinfo(m, file); - ret = seq_has_overflowed(m); out: fput(file); - return ret; + return 0; } static int seq_fdinfo_open(struct inode *inode, struct file *file) So it returns "success" when the output has overflowed? Why this, rather than returning an error? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
