On Tue, Feb 10, 2015 at 10:59:01AM -0500, Jason Baron wrote: > hmmm...but don't we need the head/tail of the list to add it back too? Ah, good point that ;-) > Further, we can't just append to tail while walking the list b/c > otherwise it can result in multiple wakeups to the same item. So I could > add to a local list, for example, in __wake_up_common(). And then just > add that to the tail once the list_for_each() finishes. True; you can do horrible things, but I think that is the safest option indeed. > In terms of the flag, maybe another option would be to have the > wait_queue_func_t return a 'ROTATE_ME' value instead > of 1, since I think we currently only make use of 0 and 1? Lets stick with the flag then. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html