On Mon, Feb 9, 2015 at 4:08 AM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > On Wed, Jan 21, 2015 at 10:42 PM, Chris Mason <clm@xxxxxx> wrote: >> On Wed, Jan 21, 2015 at 09:13:13PM +1100, Dave Chinner wrote: >>> On Mon, Dec 22, 2014 at 07:16:25PM -0500, Chris Mason wrote: >>> > The 3.19 merge window brought in a great new warning to catch someone >>> > calling might_sleep with their state != TASK_RUNNING. The idea was to >>> > find buggy code locking mutexes after calling prepare_to_wait(), kind >>> > of like this: >>> > >>> > [ 445.464634] WARNING: CPU: 22 PID: 4367 at kernel/sched/core.c:7303 __might_sleep+0x9a/0xb0() >>> > [ 445.481699] do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff81093f68>] prepare_to_wait_event+0x68/0x120 >>> >>> Hi Chris, >>> >>> This still isn't fixed in -rc5 - I'm hitting it multiple times in >>> every xfstests run I do. What's the current status of your fix? >> >> I worried this is going to have a perf hit, so I talked Jens into double >> checking it on one of his super high iop boxes. >> > > From reading the log [1] this issue seems to be fixed by... > > commit 9c9ce763b114e608b5cf3aa6cb69ad9f6e8b6adf > aio: annotate aio_read_event_ring for sleep patterns > > - Sedat - > > [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9c9ce763b114e608b5cf3aa6cb69ad9f6e8b6adf I have retested with Linux v3.19 (final) and fio-2.2.5 and the warning is gone. Testcase: # LC_ALL=C rm -v -f randread.* # sync && sync && sync # echo 3 > /proc/sys/vm/drop_caches # LC_ALL=C fio-2.2.5 --name=randread --rw=randread --bs=4k --ioengine=libaio --iodepth=64 --direct=1 --numjobs=1 --size=1024M # LC_ALL=C rm -v -f randread.* My dmesg diff: # diff -uprN dmesg_3.19.0-1-iniza-small_before-fio.txt dmesg_3.19.0-1-iniza-small_after-fio.txt --- dmesg_3.19.0-1-iniza-small_before-fio.txt 2015-02-09 05:16:36.377686868 +0100 +++ dmesg_3.19.0-1-iniza-small_after-fio.txt 2015-02-09 05:17:52.269684487 +0100 @@ -797,3 +797,4 @@ [ 697.624755] PPP BSD Compression module registered [ 697.638376] PPP Deflate Compression module registered [ 720.366430] usb 4-1.5: USB disconnect, device number 4 +[ 786.772407] bash (2806): drop_caches: 3 - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
