On Thu, Jan 29, 2015 at 01:46:30PM +0100, Jan Kara wrote: > Thanks for pointing this out. You made me at look where exactly is > get_write_access() called and there are even places where we call it > without having file descriptor at all (e.g. truncate path). So ext3, ext4, > udf, and gfs2 are racy. If we race, results aren't that bad (we just keep > preallocated blocks in the inode) but still it would be nice to fix. > > Obviously we could maintain a private writecount in ->open() method but it > would seem a bit sad to do that for this mostly theoretical issue. Maybe we > just verify whether preallocation is truncated when evicting inode from > memory and if not, do it there. It's not perfect but even with current racy > solution noone noticed in practice. The trouble with doing that on inode eviction is that we might have done r/o remount by then, so any metadata writes are unexpected at that point... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
