On Mon, Jan 26, 2015 at 11:57:30AM -0800, Mandeep Sandhu wrote: > >> + > >> + ret = kobject_set_name(&idev->device.kobj, "uio%d", idev->minor); > > > > dev_set_name()? > > There's another instance of use of kobject_set_name in > uio_major_init(). Should I change that too ,or that should be done in > a new (unrelated) patch? Unrelated please, one logical change per patch is the rules. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html