On Fri, Jan 23, 2015 at 03:09:20PM -0600, Christoph Lameter wrote: > On Fri, 23 Jan 2015, Guenter Roeck wrote: > > > Wouldn't that have unintended consequences ? So far > > rb tree nodes are allocated even if a node not online; > > the above would change that. Are you saying it is > > unnecessary to initialize rb tree nodes if the node > > is not online ? > > It is not advisable to allocate since an offline node means that the > structure cannot be allocated on the node where it would be most > beneficial. Typically subsystems allocate the per node data structures > when the node is brought online. I would generally agree, but this code, which implements a userspace interface, is already grotesquely inefficient and heavyhanded. It's also superseded in the next release, so we can just keep this simple at this point. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
