On Sun, Jan 11, 2015 at 12:42:42PM +0100, Christoph Hellwig wrote: > On Fri, Jan 09, 2015 at 03:02:02PM -0800, Tom Haynes wrote: > > > > > - READ_BUF(12); > > > len += 12; > > > > I think this code makes it clear that the magic number 12 is the > > same on both lines. With the change, that gets lost. > > > > Do I think that the 12 will ever change? No. > > > > Do I think this becomes more "magic"? Yes. > > Sure. but the whole counting the number to be decoded in setattr > is magic to start with. Agreed. > I guess we could replace it with some magic > pointer arithmetic on argp->p, but is that really worth it? Which is why I asked the leading questions. I see both sides, but ultimately it is a nit considering the rest of the abuse. I'm fine with you deciding it is still magic overall. > Should > be a separate patch for sure. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
