Kirill A. Shutemov wrote on Fri, Jan 09, 2015 at 03:20:51PM +0200: > > Your patch will not BUG() if status is junk, BUT if status uninitialized > > value is 0 and p9_client_lock_dotl then we'll return res=0 (success) and > > not unlock before returning. My patch makes sure we'll return -ENOLCK. > > No, if p9_client_lock_dotl() return 0 it must set status. If it's not, > that's bug on p9_client_lock_dotl() side and must be fixed. I had that bit right, but I only remembered your second patch -- sorry. It should be fine with your patchES, please disregard this one. -- Dominique Martinet, CEA -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html