On 23.12.2014 02:51, Christoph Hellwig wrote: > On Mon, Dec 22, 2014 at 12:48:43PM +0100, Dongsu Park wrote: > > From: Kent Overstreet <kmo@xxxxxxxxxxxxx> > > > > Increase bio->bi_remaining instead of calling bio_get(), > > and call bio_end() instead of bio_put() upon buffer_head submission. > > Nees an explanation on why this is done. Right. > > Also make bio submission in kernel/power/block_io.c to properly submit > > bios by checking whether bio_chain is available or not. > > Should be a separate patch. > > And of course both should go into the preparation series of cleanups. Yep, agreed. I'll split it up and also move them to the prep series. Thanks, Dongsu -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html