On Thu, Dec 18, 2014 at 9:07 AM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > Why is this piece of code using its own made up and buggy list handling in > the first place? We have list functions for these things, exactly so that > people shouldn't write buggy stuff by hand. Oh. Ok, I see what's going on. We have "list_splice()", but we don't have the equivalent "hlist_splice()". So it's doing that by hand, and did it badly. Al, this is your bug. I guess I can take the "manual hlist_splice" fix from Eric, but I'm not really happy with it. There's a few other places in that same commit where the list splice operation has been open-coded. Mind taking a look? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html