Hi Changman, > -----Original Message----- > From: Changman Lee [mailto:cm224.lee@xxxxxxxxx] > Sent: Wednesday, December 17, 2014 11:20 PM > To: Chao Yu > Cc: Jaegeuk Kim; Changman Lee; linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [f2fs-dev] [PATCH v2] f2fs: use ra_meta_pages to simplify readahead code in > restore_node_summary > > Hi, > > Is there any reason to use truncate_inode_pages_range instead of > invalidate_mapping_pages? > IMHO, it seems nice to just use invalidate_mapping_pages because pages > of meta_inode shouldn't be dirty, locked, under writeback or mapped in > this function. > If there is my misunderstanding, let me know. I think you're right, I use truncate_inode_pages_range because just following the usage of readahead-invalidate pair in recovery flow, but without considering the difference between them. I will fix this as you suggested. > > Thanks, > > Reviewed-by: Changman Lee <cm224.lee@xxxxxxxxxxx> And thanks for your review! :) Regards, Yu -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
