Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@xxxxxxxxxx] > Sent: Wednesday, December 17, 2014 2:05 PM > To: Chao Yu > Cc: Changman Lee; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [f2fs-dev][PATCH] f2fs: use ra_meta_pages to simplify readahead code in > restore_node_summary > > Hi Chao, > > On Thu, Dec 11, 2014 at 06:16:27PM +0800, Chao Yu wrote: > > Use more common function ra_meta_pages() with META_POR to readahead node blocks > > in restore_node_summary() instead of ra_sum_pages(), hence we can simplify the > > readahead code there, and also we can remove unused function ra_sum_pages(). > > > > Signed-off-by: Chao Yu <chao2.yu@xxxxxxxxxxx> > > --- > > fs/f2fs/node.c | 67 ++++++++++++---------------------------------------------- > > 1 file changed, 14 insertions(+), 53 deletions(-) [snip] > > - invalidate_mapping_pages(inode->i_mapping, addr, > > - addr + nrpages); > > + truncate_inode_pages_range(META_MAPPING(sbi), > > + addr, addr + nrpages); > > I found a bug here. :) Thank you for your review! :) > The truncate_inode_pages_range uses start and end parameters as byte offsets. > So, you should use like (addr << PAGE_CACHE_SHIFT). > Yes, you're correct, I will fix this and send v2 patch. Regards, Yu > Thanks, > > > } > > - return err; > > + return 0; > > } > > > > static void remove_nats_in_journal(struct f2fs_sb_info *sbi) > > -- > > 2.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
