On Mon, 2014-11-10 at 06:19 -0800, Christoph Hellwig wrote: > Looks like there is no real dependency between these patches, so we > might take on each through the libata, scsi and block trees. > > Can I get another review for the sd patch, please? > The changes in [PATCH 2/3] sd: Disable discard_zeroes_data for UNMAP look fine to me. I was wondering, though, if the changes to add the "devices_handle_discard_safely" module parameter to the MD raid drivers are really needed if this is fixed. (It's great to be able to disable the use of discard if desired, but how is an administrator actually supposed to know if the devices they have *really* work properly?) Maybe the default value of this parameter should be changed, or the parameter should be changed to have an inverse sense, i.e. "disable use of discard"... -Ewan -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
