On Mon 2014-11-10 10:58:57, Joe Perches wrote: > Using the return value of seq_putc is error-prone, so > make it return void instead. > > Reverse the logic in seq_putc to make it like seq_puts. > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Reviewed-by: Petr Mladek <pmladek@xxxxxxx> The changes are correct. The show() functions should return 0 even when there is an overflow. They are called by traverse() from seq_read() that might increase the buffer size and try again. Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html