On Mon 10-11-14 23:34:15, Christoph Hellwig wrote: > On Mon, Nov 10, 2014 at 09:30:29PM +0100, Jan Kara wrote: > > So what I somewhat dislike about this patch is that notify_change() is > > sometimes called with dentry and sometimes with path. That way it's not > > completely clear when fanotify events will be generated and when not. > > Sadly it isn't easy to provide struct path in all the places where we are > > calling notify_change() so I'm not sure what would a better solution look > > like either :( > > I suspect the right thing to do is to split out the truncate path > from notify_change, as it's fairly different anyway. Yeah, that would make sense. I wanted to say it's quite a lot of work to change all the filesystems (where the separation of truncate path makes sense as well IMHO) but actually it's possible to just do the separation at the VFS level and still call ->setattr() fs callback for now. Heinrich will you look into this? Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
