On 06.11.2014 14:03, Jan Kara wrote:
destroy_list is used to track marks which still need waiting for srcu period end before they can be freed. However by the time mark is added to destroy_list it isn't in group's list of marks anymore and thus we can reuse fsnotify_mark->g_list for queueing into destroy_list. This saves two pointers for each fsnotify_mark.
With your patch the information how g_list is used is only provided in the commit message (same is true for obj_list in PATCH 2/3).
Please, provide comments for the fields of structure fsnotify_mark in include/linux/fsnotify_backend.h indicating how these fields are used.
Especially if a field is reused for different purposes, as you now suggest for g_list (and obj_list), this information is indispensable.
Best regards Heinrich Schuchardt -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
