On Tue, 2014-11-04 at 16:26 +0000, Elliott, Robert (Server Storage) wrote: > > > -----Original Message----- > > From: Boaz Harrosh [mailto:boaz@xxxxxxxxxxxxx] > > Sent: Tuesday, 04 November, 2014 4:38 AM > > To: Wilcox, Matthew R; Elliott, Robert (Server Storage); Ross > > Zwisler; Jens Axboe; Nick Piggin; Kani, Toshimitsu; Knippers, Linda; > > linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > > nvdimm@xxxxxxxxxxxx; Matthew Wilcox > > Subject: Re: [PATCH 1/4] pmem: Initial version of persistent memory > > driver > > > > On 11/03/2014 06:19 PM, Wilcox, Matthew R wrote: > ... > > > > I wish you guys would actually review the correct code. > > > > In the actual good driver that has any shape of proper code all these > > issue are gone. > > > > * config defaults gone, multiple-devices multiple-memory ranges fully > > supported hot plug style. > > * above shifts cruft completely gone it is left overs from brd.c and > > its page usage. > > * getgeo fixed to do what we realy want by the only application on earth > > that still uses it, fdisk. All other partitioners do not call it at > > all. > > > > Why are we reviewing dead code ? > > > > Cheers > > Boaz > > Ross, what's the status of Boaz' patches (available in > git://git.open-osd.org/pmem.git)? > > https://github.com/01org/prd.git doesn't include any of > them yet. Hey Robert, The UEFI organization is in the process of defining a generic specification for platform non-volatile memory resources. Essentially the thought was to wait until that was publicly available before adding any new device discovery capabilities to pmem. What Boaz has suggested and coded up is certainly useful, but the worry is that it will end up being incompatible with what comes out of UEFI. If we stay with the dead-simple module parameter method, we will have less code to unwind later. Thanks, - Ross -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
