Re: [v5 4/5] Adds ioctl interface support for ext4 project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On October 26, 2014 6:22:52 AM CET, Li Xi <pkuelelixi@xxxxxxxxx> wrote:

> #define EXT4_IOC_PRECACHE_EXTENTS	_IO('f', 18)
>+#define EXT4_IOC_GETPROJECT		_IOR('f', 19, long)
>+#define EXT4_IOC_SETPROJECT		_IOW('f', 20, long)


>+		projid = (__u32)from_kprojid(&init_user_ns,
>+					     EXT4_I(inode)->i_projid);
>+		return put_user(projid, (__u32 __user *) arg);
>+	}
>+	case EXT4_IOC_SETPROJECT:
>+	{
>+		__u32 projid;
>+
>+		if (get_user(projid, (__u32 __user *) arg))
>+			return -EFAULT;
>+
>+		return ext4_ioctl_setproject(filp, 

Types don't match. Please use __u32 in the command definition instead of long, otherwise 32 bit compact won't work.

     Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux